Difference between revisions of "Developer Meetings/20130326"

From Slicer Wiki
Jump to: navigation, search
m (Text replacement - "slicerWiki/index.php" to "wiki")
 
(28 intermediate revisions by 5 users not shown)
Line 1: Line 1:
http://wiki.slicer.org/slicerWiki/index.php/Developer_Meetings/20130226#Module_reorganization
+
__TOC__
  
*installed extensions do not display their logos but a generic image. Why?
+
== To discuss ==
 +
*the discussion about how to reorganize the modules in Slicer should continue.
 +
http://wiki.slicer.org/wiki/Developer_Meetings/20130226#Module_reorganization
 +
 
 +
*installed extensions do not display their logos but a generic image. Why?  
 +
** Jc: See Issue [http://www.na-mic.org/Bug/view.php?id=1907 1907]
 
[[image:Screen Shot 2013-03-20 at 3.18.35 PM.png|200px|thumb|right|This generic logo is displayed for all installed extensions]]
 
[[image:Screen Shot 2013-03-20 at 3.18.35 PM.png|200px|thumb|right|This generic logo is displayed for all installed extensions]]
 +
 +
*the majority of the extensions do not have "advertising" information available. Where does this information come from?
 +
[[image:Screen Shot 2013-03-20 at 3.19.05 PM.png|200px|thumb|right|This is an example of the lack of advertising information that should be provided. virtually none of the extensions have that information available.]]
 +
 +
*The social media buttons do not work. What is their function?
 +
** Jc: Waiting the functionality is implemented. Button will be hidden. See [https://github.com/midasplatform/slicerappstore/pull/38 slicerappstore/pull/38]  [[image:Screen Shot 2013-03-20 at 3.28.33 PM.png|200px|thumb|right|These buttons do not do anything right now. If they were functional, what would they accomplish?]]
 +
[[image:Bad-aspect-ratio-Screen Shot 2013-03-26 at 7.59.29 AM.png|200px|thumb|right|The squashed images look terrible.  Also note that even the
 +
social network icons are incorrectly resized so that google plus turns into google minus!  Fail.]]
 +
 +
* Extension screenshots have the wrong aspect ratio
 +
** appstore code should letterbox the images and not do a non-uniform scale
 +
 +
* The locale issue - who will take this on?
 +
** http://www.na-mic.org/Bug/view.php?id=3029
 +
 +
* Release scheduling for 4.3, 4.4 ([http://www.na-mic.org/Bug/roadmap_page.php Roadmap])
 +
** Remaining ITKv4 issues (broken CLIs, failing tests, win32 builds, others...?)
 +
** Turning on SimpleITK
 +
 +
*Ohloh presence:
 +
<pre>
 +
From Jc:
 +
There are currently three results for "Slicer4. See http://www.ohloh.net/p?q=slicer4
 +
- Slicer4:  http://www.ohloh.net/p/slicer
 +
- pieper's Slicer4:  http://www.ohloh.net/p/piepers_Slicer4
 +
- Slicer: http://www.ohloh.net/p/3376
 +
We should either have just "Slicer" / "3DSlicer"
 +
or on project for each version:
 +
  3DSlicer 2
 +
  3DSlicer 3
 +
  3DSlicer 4
 +
I would suggest the first approach.
 +
Hth
 +
Jc
 +
</pre>
 +
{{pre2|
 +
From Julien:
 +
I don't think ohloh is meant to host multiple versions of the same project, I would advise against having multiple versions on ohloh. Especially because Slicer3 is not active anymore and Slicer4 is built on top of Slicer3, it contains all the Slicer3 information.
 +
If you look at the top 50 projects in ohloh, none of them are related to a specific version.
 +
Julien.
 +
}}
 +
 +
*Model Hierarchies plus scene views
 +
** Crash on restoring Visual System scene view in Brain Atlas only after going into Models module [http://www.na-mic.org/Bug/view.php?id=2557 2557]
 +
 +
* CMake'ified python: https://github.com/jcfr/Slicer/tree/use-cmakeified-python
 +
** Compiles platform (Win-64 VS2008, Ubuntu 10.04 gcc 4.4.3, macosx XCode 4.6 [gcc 4.2.1])
 +
** Currently investigating:
 +
*** Windows: Crash on start.
 +
*** Linux: Failed to import some module.
 +
 +
 +
== Conclusion ==
 +
* Discussed module re-organization
 +
** The idea would be to move every "legacy" cli into an extension and create a "meta" extension allowing to install all these cli modules at ones.
 +
** Andriy is clarifying with Andras and Tamas the move of MRIBiasFieldCorrection" into legacy category.
 +
*** Andras reported that if N4ITKBiasFieldCorrection has similar functionality, it should be fine. He also reported some issue with the module. See http://www.na-mic.org/Bug/view.php?id=3034
 +
 +
* Ron asked where the extension description should be entered so that it appear on the extension catalog.
 +
** Description of extension lives in the extension metadata specified in the CMakeLists.txt of the extension. For example: https://github.com/Slicer/SkullStripper/blob/master/CMakeLists.txt#L5-11
 +
** Using the metadata from the CMakeLists, the extension description file is then generated and added to the ExtensionsIndex. See https://github.com/Slicer/ExtensionsIndex/blob/master/SkullStripper.s4ext#L37-38
 +
 +
*Ohloh presence: All agree we should have on entry named "Slicer".
 +
 +
* Extensions catalog: Extension screenshots have the wrong aspect ratio
 +
** Issue has been reported. See https://github.com/midasplatform/slicerappstore/issues/39
 +
 +
* Nicole, Sankhesh and Julien discussed the "Model Hierarchies" +  "scene views" issue.
 +
 +
* Also discussed the current documentation system:
 +
** Developer documentation should belong to code base
 +
** User manual should be editable by both developer and user
 +
** Current documentation system (wiki) need to be updated to be more user-friendly.
 +
 +
* Jc: Will be adding a "Developer Tools" option in the setting
 +
** When enabled, it will show the developer category in the module menu.
 +
 +
* CLI category
 +
** Slicer should propose a mechanism to map CLI to different category. Application specific category shouldn't be added to the CLI itself.
 +
 +
* Internationalization
 +
** We reach consensus: Official support for i18n will be disabled. A CMake option named Slicer_BUILD_I18N_SUPPORT will be added and the option won't be actively supported or tested.
 +
** Why? Supporting internationalization properly would require to test all ITK/VTK/Teem/.. readers and we don't have the funding or resources to support that effort. If it is something you are interested in, make sure to drop an email on the developer list. We will be happy to provide more information.
 +
** Issues: [http://www.na-mic.org/Bug/view.php?id=3029 3029]
 +
** Additional note will be tracked on the following page: http://www.slicer.org/wiki/Documentation/Labs/I18N

Latest revision as of 17:05, 21 November 2019

Home < Developer Meetings < 20130326

To discuss

  • the discussion about how to reorganize the modules in Slicer should continue.

http://wiki.slicer.org/wiki/Developer_Meetings/20130226#Module_reorganization

  • installed extensions do not display their logos but a generic image. Why?
This generic logo is displayed for all installed extensions
  • the majority of the extensions do not have "advertising" information available. Where does this information come from?
This is an example of the lack of advertising information that should be provided. virtually none of the extensions have that information available.
  • The social media buttons do not work. What is their function?
    • Jc: Waiting the functionality is implemented. Button will be hidden. See slicerappstore/pull/38
      These buttons do not do anything right now. If they were functional, what would they accomplish?
The squashed images look terrible. Also note that even the social network icons are incorrectly resized so that google plus turns into google minus! Fail.
  • Extension screenshots have the wrong aspect ratio
    • appstore code should letterbox the images and not do a non-uniform scale
  • Release scheduling for 4.3, 4.4 (Roadmap)
    • Remaining ITKv4 issues (broken CLIs, failing tests, win32 builds, others...?)
    • Turning on SimpleITK
  • Ohloh presence:
From Jc:
There are currently three results for "Slicer4. See http://www.ohloh.net/p?q=slicer4
 - Slicer4:  http://www.ohloh.net/p/slicer
 - pieper's Slicer4:  http://www.ohloh.net/p/piepers_Slicer4
 - Slicer: http://www.ohloh.net/p/3376
We should either have just "Slicer" / "3DSlicer"
or on project for each version:
  3DSlicer 2
  3DSlicer 3
  3DSlicer 4
I would suggest the first approach.
Hth
Jc
From Julien:
I don't think ohloh is meant to host multiple versions of the same project, I would advise against having multiple versions on ohloh. Especially because Slicer3 is not active anymore and Slicer4 is built on top of Slicer3, it contains all the Slicer3 information.
If you look at the top 50 projects in ohloh, none of them are related to a specific version.
Julien.
  • Model Hierarchies plus scene views
    • Crash on restoring Visual System scene view in Brain Atlas only after going into Models module 2557


Conclusion

  • Discussed module re-organization
    • The idea would be to move every "legacy" cli into an extension and create a "meta" extension allowing to install all these cli modules at ones.
    • Andriy is clarifying with Andras and Tamas the move of MRIBiasFieldCorrection" into legacy category.
  • Ohloh presence: All agree we should have on entry named "Slicer".
  • Nicole, Sankhesh and Julien discussed the "Model Hierarchies" + "scene views" issue.
  • Also discussed the current documentation system:
    • Developer documentation should belong to code base
    • User manual should be editable by both developer and user
    • Current documentation system (wiki) need to be updated to be more user-friendly.
  • Jc: Will be adding a "Developer Tools" option in the setting
    • When enabled, it will show the developer category in the module menu.
  • CLI category
    • Slicer should propose a mechanism to map CLI to different category. Application specific category shouldn't be added to the CLI itself.
  • Internationalization
    • We reach consensus: Official support for i18n will be disabled. A CMake option named Slicer_BUILD_I18N_SUPPORT will be added and the option won't be actively supported or tested.
    • Why? Supporting internationalization properly would require to test all ITK/VTK/Teem/.. readers and we don't have the funding or resources to support that effort. If it is something you are interested in, make sure to drop an email on the developer list. We will be happy to provide more information.
    • Issues: 3029
    • Additional note will be tracked on the following page: http://www.slicer.org/wiki/Documentation/Labs/I18N