Difference between revisions of "Developer Meetings/20130219"

From Slicer Wiki
Jump to: navigation, search
m
 
(7 intermediate revisions by 2 users not shown)
Line 1: Line 1:
 +
 +
__TOC__
 +
 
== To discuss ==
 
== To discuss ==
 
* Integration of Laurent contribution to Annotation: https://github.com/lchauvin/Slicer/commit/9d2c15b676c69256b37badac9862fcf0143b0728
 
* Integration of Laurent contribution to Annotation: https://github.com/lchauvin/Slicer/commit/9d2c15b676c69256b37badac9862fcf0143b0728
 +
* Failed test "vtkSlicerModelsLogicAutoRemoveTest" - See http://www.na-mic.org/Bug/view.php?id=2916
 +
* Failed tests due to ITKv4 - See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2013/011451.html
 +
* Nifti reader for VTK - See http://www.vtk.org/pipermail/vtk-developers/2013-February/012932.html
 +
 +
* Cleanup: Move the following classes from <code>Base/Logic</code> to <code>Modules/Scripted/Editor/Logic</code> or <code>Modules/Scripted/EditorLib/Logic</code ? This classes are used exclusively by the editor module.
 +
vtkImageErode
 +
vtkImageFillROI
 +
vtkImageLabelChange
 +
vtkImageSlicePaint
 +
vtkImageStash
 +
vtkImageConnectivity (Also used within CLI DiffusionWeightedVolumeMasking)
 +
* Cleanup: Remove <code>Base/Logic/vtkImageRectangularSource</code> ? In the comment at the top of the class, it is mentioned it was used as a test but there are no test. Additionally class <code>vtkImageDilateErode3D</code> now lives in VTK proper.
 +
<pre>
 +
/// vtkImageRectangularSource creates a binary image of a ellipsoid.  It was created
 +
/// as an example of a simple source, and to test the mask filter.
 +
/// It is also used internally in vtkImageDilateErode3D.
 +
</pre>
 +
* Cleanup: Are the following classes used ? They are not referenced anywhere in Slicer. May be in some extension ?
 +
vtkPichonFastMarching
 +
vtkPichonFastMarchingPDF
 +
* Cleanup: Move <code>Base/Logic/vtkSlicerFiducialsLogic</code> into Annotation logic? This class is used only by <code>vtkSlicerAnnotationModuleLogic</code>
 +
* Cleanup: Remove class <code>Base/Logic/vtkSlicerGlyphSource2D</code> ? Doesn't seem to be used. This class has originally been added by [http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=2013 r2013] to ''make a new starburst glyph''.
 +
** Instead, the VTK class should be extended and improvement contributed.
 +
* Cleanup: Remove class <code>Base/Logic/vtkSlicerROILogic</code> ? Not user anywhere. This class was originally used by <code>vtkSlicerROIGUI</code> which has been removed with [http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=16260 r16260]
 +
<!--
 +
* Cleanup: Remove class <code>Base/Logic/vtkSystemInformation</code> ?
 +
** Used only in Performance.py module to [https://github.com/Slicer/Slicer/blob/master/Modules/Scripted/Scripts/PerformanceTests.py#L258-261 get memory info].
 +
** If the intent is to have this information available from python, the class could probably be added to ctk as ctkVTKSystemInformation ? Finally, memory information should probably be added to the Slicer about dialog.
 +
-->
 +
* Cleanup: Move <code>Base/Logic/Resources/ColorFiles</code> to <code>Modules/Loadable/Color/Resources/ColorFiles</code> ?
 +
* Cleanup: Move <code>Base/GUI/Tcl/ImageData/*.png</code> to <code>Modules/Scripted/EditorLib/Resources/</code> ?
 +
 +
* Review failing tests and issues
 +
** memory management of qt items with PythonQt http://na-mic.org/Bug/view.php?id=2964
 +
** crashes due to destructors of DCMTK singletons (GlobalDcmDataDictionary this time) -- can we build with dynamic DCMTK? http://www.na-mic.org/Bug/view.php?id=2963
 +
 +
* Extension Bundle Template
 +
** Should include top level cmake and stubbed out examples for one of each scripted, loadable, and CLI module
 +
** Suggested starting point for extension developers
 +
** Basis for detailed walkthrough tutorial
  
 
== Conclusion ==
 
== Conclusion ==

Latest revision as of 20:41, 19 February 2013

Home < Developer Meetings < 20130219

To discuss

  • Cleanup: Move the following classes from Base/Logic to Modules/Scripted/Editor/Logic or Modules/Scripted/EditorLib/Logic</code ? This classes are used exclusively by the editor module.
vtkImageErode
vtkImageFillROI
vtkImageLabelChange
vtkImageSlicePaint
vtkImageStash
vtkImageConnectivity (Also used within CLI DiffusionWeightedVolumeMasking)
  • Cleanup: Remove Base/Logic/vtkImageRectangularSource ? In the comment at the top of the class, it is mentioned it was used as a test but there are no test. Additionally class vtkImageDilateErode3D now lives in VTK proper.
/// vtkImageRectangularSource creates a binary image of a ellipsoid.  It was created
/// as an example of a simple source, and to test the mask filter.
/// It is also used internally in vtkImageDilateErode3D.
  • Cleanup: Are the following classes used ? They are not referenced anywhere in Slicer. May be in some extension ?
vtkPichonFastMarching
vtkPichonFastMarchingPDF
  • Cleanup: Move Base/Logic/vtkSlicerFiducialsLogic into Annotation logic? This class is used only by vtkSlicerAnnotationModuleLogic
  • Cleanup: Remove class Base/Logic/vtkSlicerGlyphSource2D ? Doesn't seem to be used. This class has originally been added by r2013 to make a new starburst glyph.
    • Instead, the VTK class should be extended and improvement contributed.
  • Cleanup: Remove class Base/Logic/vtkSlicerROILogic ? Not user anywhere. This class was originally used by vtkSlicerROIGUI which has been removed with r16260
  • Cleanup: Move Base/Logic/Resources/ColorFiles to Modules/Loadable/Color/Resources/ColorFiles ?
  • Cleanup: Move Base/GUI/Tcl/ImageData/*.png to Modules/Scripted/EditorLib/Resources/ ?
  • Extension Bundle Template
    • Should include top level cmake and stubbed out examples for one of each scripted, loadable, and CLI module
    • Suggested starting point for extension developers
    • Basis for detailed walkthrough tutorial

Conclusion
Retrieved from "https://www.slicer.org/w/index.php?title=Developer_Meetings/20130219&oldid=30555"