Difference between revisions of "Developer Meetings/20130219"
From Slicer Wiki
m (→To discuss) |
m (→To discuss) |
||
| Line 7: | Line 7: | ||
* Failed tests due to ITKv4 - See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2013/011451.html | * Failed tests due to ITKv4 - See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2013/011451.html | ||
| − | * Cleanup: Move the following classes from <code>Base/Logic</code> to <code>Modules/Scripted/Editor/Logic</code> ? This classes are used exclusively by the editor module. | + | * Cleanup: Move the following classes from <code>Base/Logic</code> to <code>Modules/Scripted/Editor/Logic</code> or <code>Modules/Scripted/EditorLib/Logic</code ? This classes are used exclusively by the editor module. |
vtkImageErode | vtkImageErode | ||
vtkImageFillROI | vtkImageFillROI | ||
| Line 14: | Line 14: | ||
vtkImageStash | vtkImageStash | ||
vtkImageConnectivity (Also used within CLI DiffusionWeightedVolumeMasking) | vtkImageConnectivity (Also used within CLI DiffusionWeightedVolumeMasking) | ||
| − | * Cleanup: Remove <code>Base/Logic/vtkImageRectangularSource</code> ? In the comment at the top of the class, it is mentioned it was used as a test but there are no test. Additionally class vtkImageDilateErode3D now lives in VTK proper. | + | * Cleanup: Remove <code>Base/Logic/vtkImageRectangularSource</code> ? In the comment at the top of the class, it is mentioned it was used as a test but there are no test. Additionally class <code>vtkImageDilateErode3D</code> now lives in VTK proper. |
<pre> | <pre> | ||
/// vtkImageRectangularSource creates a binary image of a ellipsoid. It was created | /// vtkImageRectangularSource creates a binary image of a ellipsoid. It was created | ||
| Line 32: | Line 32: | ||
** If the intent is to have this information available from python, the class could probably be added to ctk as ctkVTKSystemInformation ? Finally, memory information should probably be added to the Slicer about dialog. | ** If the intent is to have this information available from python, the class could probably be added to ctk as ctkVTKSystemInformation ? Finally, memory information should probably be added to the Slicer about dialog. | ||
--> | --> | ||
| − | * Cleanup: Move | + | * Cleanup: Move <code>Base/Logic/Resources/ColorFiles</code> to <code>Modules/Loadable/Color/Resources/ColorFiles</code> ? |
| + | * Cleanup: Move <code>Base/GUI/Tcl/ImageData/*.png</code> to <code>Modules/Scripted/EditorLib/Resources/</code> ? | ||
== Conclusion == | == Conclusion == | ||
Revision as of 05:37, 19 February 2013
Home < Developer Meetings < 20130219Contents
To discuss
- Integration of Laurent contribution to Annotation: https://github.com/lchauvin/Slicer/commit/9d2c15b676c69256b37badac9862fcf0143b0728
- Failed test "vtkSlicerModelsLogicAutoRemoveTest" - See http://www.na-mic.org/Bug/view.php?id=2916
- Failed tests due to ITKv4 - See http://massmail.spl.harvard.edu/public-archives/slicer-devel/2013/011451.html
- Cleanup: Move the following classes from
Base/LogictoModules/Scripted/Editor/LogicorModules/Scripted/EditorLib/Logic</code ? This classes are used exclusively by the editor module.
vtkImageErode
vtkImageFillROI
vtkImageLabelChange
vtkImageSlicePaint
vtkImageStash
vtkImageConnectivity (Also used within CLI DiffusionWeightedVolumeMasking)
- Cleanup: Remove
Base/Logic/vtkImageRectangularSource ? In the comment at the top of the class, it is mentioned it was used as a test but there are no test. Additionally class vtkImageDilateErode3D now lives in VTK proper.
/// vtkImageRectangularSource creates a binary image of a ellipsoid. It was created
/// as an example of a simple source, and to test the mask filter.
/// It is also used internally in vtkImageDilateErode3D.
- Cleanup: Are the following classes used ? They are not referenced anywhere in Slicer. May be in some extension ?
vtkPichonFastMarching
vtkPichonFastMarchingPDF
- Cleanup: Move
Base/Logic/vtkSlicerFiducialsLogic into Annotation logic? This class is used only by vtkSlicerAnnotationModuleLogic
- Cleanup: Remove class
Base/Logic/vtkSlicerGlyphSource2D ? Doesn't seem to be used. This class has originally been added by r2013 to make a new starburst glyph.
- Instead, the VTK class should be extended and improvement contributed.
- Cleanup: Remove class
Base/Logic/vtkSlicerROILogic ? Not user anywhere. This class was originally used by vtkSlicerROIGUI which has been removed with r16260
- Cleanup: Move
Base/Logic/Resources/ColorFiles to Modules/Loadable/Color/Resources/ColorFiles ?
- Cleanup: Move
Base/GUI/Tcl/ImageData/*.png to Modules/Scripted/EditorLib/Resources/ ?
Conclusion
