Difference between revisions of "Qt in Slicer3"

From Slicer Wiki
Jump to: navigation, search
Line 38: Line 38:
 
* There are '''3309''' KWWidgets instances created in slicer core and modules (calls to New)
 
* There are '''3309''' KWWidgets instances created in slicer core and modules (calls to New)
 
* These calls are from '''123''' different KWWidget classes (including 'pure' KW classes in slicer that only depend on vtkKW and not MRML or other slicer code)  
 
* These calls are from '''123''' different KWWidget classes (including 'pure' KW classes in slicer that only depend on vtkKW and not MRML or other slicer code)  
 +
* '''37''' KKWidgets subclasses are vtkKWMimx classes in the Meshing module
 
* There are '''105''' classes that subclass from KWWidget classes
 
* There are '''105''' classes that subclass from KWWidget classes
  
Line 43: Line 44:
 
  grep -r vtkKW . | grep -v svn | grep New | wc
 
  grep -r vtkKW . | grep -v svn | grep New | wc
 
  grep -r vtkKW . | grep -v svn | grep "::New" | tr " " "\n" | tr "=" "\n" | tr ">" "\n" | grep -v "^//" | grep "vtkKW.*New" | sed 's/::New.*//' | sort | uniq | wc
 
  grep -r vtkKW . | grep -v svn | grep "::New" | tr " " "\n" | tr "=" "\n" | tr ">" "\n" | grep -v "^//" | grep "vtkKW.*New" | sed 's/::New.*//' | sort | uniq | wc
 +
grep -r vtkKW . | grep -v svn | grep "::New" | tr " " "\n" | tr "=" "\n" | tr ">" "\n" | grep -v "^//" | grep "vtkKW.*New" | sed 's/::New.*//' | sort | uniq | grep Mimx |  wc
 
  grep -r vtkKW . | grep -v svn | grep public | wc'
 
  grep -r vtkKW . | grep -v svn | grep public | wc'
  

Revision as of 21:35, 10 September 2009

Home < Qt in Slicer3

This page captures the design considerations about moving Slicer3 from KWWidgets to Qt. As of August 2009 there are no concrete plans for a switch; however there is significant momentum around Qt as an open source technology and interest in making it available to the Slicer community.

Background

When Slicer3 was being designed in 2004 Qt was available only under the GPL license or a commercial (pay) license (See the wikipedia discussion) and neither license option was acceptable to the community. In March 2009 Qt 4.5 was released under the LGPL license and became a possible technology for use in Slicer.

Slicer3 is implemented using KWWidgets which has proven to be extremely capable and robust. However, due to the small size of the developer team for KWWidgets Kitware has been clear that it will not be able to compete with the features being added to Qt and is in fact adopting Qt for many of its internal projects (see, for example, ParaView which migrated to Qt over the past several years).

Experiments

Screenshot from a version of slicer that has Qt accessible from the python console.

In August of 2009 several members of the slicer development team have been learning about Qt and reviewing options. Things that are currently working:

  • Qt and KWWidgets can co-exist in same application environment (in different top level windows).
  • Qt widgets interfaces can be assembled using the QtDesigner, C++, or python.
  • It is feasible to create slicer widgets that use Qt (e.g. a NodeSelector widget).

Overall the experience has been positive but the experiments have shown that there will be a significant amount of programming work to be done for each part of the interface. Most of the work is probably best characterized as "easy but time consuming". The net result of converting is expected to be positive but it is likely to be several years for there to be a payoff in terms of overall increased developer productivity and improved functionality of the overall package.

Development Plan Option for Transition to Qt

The following is a summary of the work to be done organized in a more-or-less priority order that would allow a transition in-place of functionality from KWW to Qt.

  1. Configure CPack to include Qt libraries and turn on Qt support by default in nightly builds of slicer
  2. Create prototype modules built using Qt (these would appear in a distinct top level window from the rest of slicer. The size and position would be under programatic control to make the two interface somewhat unified).
  3. Migrate the vtkSlicerViewerWidget, vtkSlicerSliceControllerWidget, and vtkSlicerSliceWidget from KWW to Qt. This would allow the right side (2D/3D viewers) of the interface to exist in Qt with the left side (module interfaces) to exist in KWWidgets.
  4. Migrate interfaces from modules and left side functions into Qt
    1. the menu bar, tool bar, modules menu, module search and history controls
    2. the CommandLineModuleGUI (so CLI modules will work in Qt)
    3. the "Manipulate Slice Views" and "Manipulate 3D View" controls
  5. Transition other dialogs and modules to Qt
    1. Add Data, Add Volume, Save, Extension Wizard, Application Settings, Cache & Remote I/O Manager, Tcl/Python Interactors, ErrorLog Dialog, Keyboard Shortcuts...
    2. Core Modules: Colors, Data, Editor, Fiducials, Measurements, Models, ROI, SlicerWelcome, Slices, Transforms, Volume Rendering, Volumes
    3. Application Modules: Change Tracker, IA_FEMesh, Qdec, FetchMI, Query Atlas, AC/PC Transform, ModelMirror, EMSegment, LabelStatistics, Tractography, Fiber Bundles, NeuroNav, OpenIGTLink IF, ProstateNav, Clip Model, Extract Subvolume ROI, 4D Volume, 4D Analysis.
    4. Extension Modules and DBP Projects: Perk Station, VMTK Vessel Tools, others...
  6. Remove KWW from the builds and do a new release.

Slicer's KWWidgets-based GUI

Statistics

  • There are 3309 KWWidgets instances created in slicer core and modules (calls to New)
  • These calls are from 123 different KWWidget classes (including 'pure' KW classes in slicer that only depend on vtkKW and not MRML or other slicer code)
  • 37 KKWidgets subclasses are vtkKWMimx classes in the Meshing module
  • There are 105 classes that subclass from KWWidget classes

Statistics methods: Calculations based on slicer3 trunk revision 10456 2009-09-10

grep -r vtkKW . | grep -v svn | grep New | wc
grep -r vtkKW . | grep -v svn | grep "::New" | tr " " "\n" | tr "=" "\n" | tr ">" "\n" | grep -v "^//" | grep "vtkKW.*New" | sed 's/::New.*//' | sort | uniq | wc
grep -r vtkKW . | grep -v svn | grep "::New" | tr " " "\n" | tr "=" "\n" | tr ">" "\n" | grep -v "^//" | grep "vtkKW.*New" | sed 's/::New.*//' | sort | uniq | grep Mimx |  wc
grep -r vtkKW . | grep -v svn | grep public | wc'

Considerations and Open Questions

  1. Coding styles and conventions for classes that interface vtk and Qt
    1. inheritance
    2. memory management
  2. a significant number of higher level Qt widgets are required (Ranges, Extents, TransferFunctionEditors, Material Properties...)
  3. Work needs to be coordinated among developers at multiple sites. Significant face-to-face time should be planned to keep everyone in sync on the progress.
  4. It will be inevitable that revisiting some modules will involve redesign and feature improvements even if our focus is specifically on swapping the GUI.
  5. Difficult bugs will occur somewhere along the process even if the plan appears smooth.
  6. We should consider training courses or conferences to get us up to speed on best practices for development. (http://www.ics.com/QuickStart/, http://qt.nokia.com/qtdevdays2009)
  7. What larger design re-works should be considered at the same time? I.e. should slicer functionality be re-organized as python packages so we can get away from the monolithic application attributes of the current main program (without a reduction in functionality or usability).

Development Approaches / Tradeoffs

Several development approaches could be taken each of which has pros/cons and risks.

  1. Immediate rewrite: this approach would be to start a from scratch to build a new GUI using Qt. Pros: likely to result in a cleaner architecture. Cons: all progress stops until new version is ready; current slicer developers are not Qt experts so not ready to build complex application from scratch; Qt does not have all the needed widgets to implement slicer (they need to be built along side slicer).
  2. Wait and see: wait until Qt more 3rd party widgets fill in the missing functionality and then do the rewrite. Cons: any new GUI development in the old framework will seem like a dead end. Pros: the current framework isn't really broken so why change?
  3. Peaceful coexistence: allow both GUI frameworks to be used together and allow people to develop in whichever is most productive for them. Cons: extra dependencies and potential maintenance issues; may require duplicated code; still need to resolve the architecture issues for mixing vtk and qt. Pros: removes pressure to do instant port; allows developers to get good at Qt before undertaking a big porting effort; allows development of 3rd party widgets that will make future ports easier.