Difference between revisions of "Developer Meetings/20150908"

From Slicer Wiki
Jump to: navigation, search
 
(6 intermediate revisions by 2 users not shown)
Line 2: Line 2:
 
* Jc:
 
* Jc:
 
** Was working on proposal. No major updates on my side.
 
** Was working on proposal. No major updates on my side.
 +
** Reviewed [https://github.com/Slicer/Slicer/pull/312 PR#312], [https://github.com/Slicer/Slicer/pull/332 PR#332] and [https://github.com/Slicer/Slicer/pull/333 PR#333]
 
* Max:
 
* Max:
 
** Addressed feedback on [https://github.com/Slicer/Slicer/pull/331 Python upgrade to 2.7.10 PR]. All commits to external packages (PythonQt, CTK, python-cmake-buildsystem) are in as of this morning.
 
** Addressed feedback on [https://github.com/Slicer/Slicer/pull/331 Python upgrade to 2.7.10 PR]. All commits to external packages (PythonQt, CTK, python-cmake-buildsystem) are in as of this morning.
 
** Re-running all tests on Windows, Linux, and Mac before creating new PR. Timeframe is EOD today.
 
** Re-running all tests on Windows, Linux, and Mac before creating new PR. Timeframe is EOD today.
 +
* Nicole
 +
** feedback requested on Editor + Scene Views bug: [http://www.na-mic.org/Bug/view.php?id=4006 4006]
 +
** screen capture scaling: vtkWindowToImageFilter vs vtkRenderLargeImage? Getting tiling artifacts in some cases. [http://www.na-mic.org/Bug/view.php?id=3885 Bug 3885]
  
 
= To Discuss=
 
= To Discuss=
 
+
* What should be done regarding PR#312 "Move to itkmghio" ? See https://github.com/Slicer/Slicer/pull/312#issuecomment-138608897
 +
* Review "Slicer 4.5 release schedule" - See https://docs.google.com/document/d/1W4fF8DceHoeKjUQzbgtd6nNAo-GAtc2v65Fv7JIfwGc/edit
  
 
= Conclusion =
 
= Conclusion =
 +
* SingletonTag has originally been added in [http://viewvc.slicer.org/viewvc.cgi/Slicer4?view=revision&revision=24520 r24520]. At that time, no serialization to MRML was added. Since then, multiple way of dealing with the "singelton-ess" of node have been implemented (Check of ID in selection node, check of tag + module name for the Editor).
 +
** As a step to (1) make things consistent and (2) address issue when an editor scripted module node is created before restoring a scene (details in [http://www.na-mic.org/Bug/view.php?id=4006 4006]), we propose to implement the serialization of the Singleton tag into MRML.
 +
** Before moving forward, we would like to get feedback from the community.

Latest revision as of 19:16, 8 September 2015

Home < Developer Meetings < 20150908

Update

  • Jc:
  • Max:
    • Addressed feedback on Python upgrade to 2.7.10 PR. All commits to external packages (PythonQt, CTK, python-cmake-buildsystem) are in as of this morning.
    • Re-running all tests on Windows, Linux, and Mac before creating new PR. Timeframe is EOD today.
  • Nicole
    • feedback requested on Editor + Scene Views bug: 4006
    • screen capture scaling: vtkWindowToImageFilter vs vtkRenderLargeImage? Getting tiling artifacts in some cases. Bug 3885

To Discuss

Conclusion

  • SingletonTag has originally been added in r24520. At that time, no serialization to MRML was added. Since then, multiple way of dealing with the "singelton-ess" of node have been implemented (Check of ID in selection node, check of tag + module name for the Editor).
    • As a step to (1) make things consistent and (2) address issue when an editor scripted module node is created before restoring a scene (details in 4006), we propose to implement the serialization of the Singleton tag into MRML.
    • Before moving forward, we would like to get feedback from the community.