Documentation/Nightly/Developers/Tutorials/MigrationGuide/ObsoleteCodeRemoval - Revision history

JChris.FillionR: /* C++11: Update source code to use = default */

2020-04-15T21:52:52Z

C++11: Update source code to use = default

2020-04-15T21:52:08Z

C++11: Update source code to use = delete

2020-04-15T21:46:59Z

Obsolete Code Removal

2020-04-15T17:50:16Z

C++11: Update source code to use = default

2019-03-16T20:41:48Z

C++11: Update source code to use = default

2019-03-16T20:38:36Z

Obsolete Code Removal

2019-03-16T19:23:19Z

C++11: Update source code to use = delete

2019-03-16T19:21:17Z

C++11: Update source code to use = delete

2019-03-16T19:20:06Z

C++11: Update source code to use = delete

2019-03-16T19:16:28Z

C++11: Update source code to use = delete

@@ Line 340: / Line 340: @@
 Add an empty space before = default if there is none:
    ack "default" -l --print0 | xargs -0 -n 1 sed -E -i 's/([^\s])= default;/\1 = default;/g'
 ===C++11: Use default member initialization ===

← Older revision		Revision as of 21:52, 15 April 2020
Line 315:		Line 315:
	Next step in this area would be to move these declarations to the public interface (currently they are private).		Next step in this area would be to move these declarations to the public interface (currently they are private).

		+	<b>References:</b>
		+
		+	https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-equals-delete.html

	===C++11: Update source code to use = default ===		===C++11: Update source code to use = default ===

← Older revision		Revision as of 21:46, 15 April 2020
Line 337:		Line 337:
	Add an empty space before = default if there is none:		Add an empty space before = default if there is none:
	ack "default" -l --print0 \| xargs -0 -n 1 sed -E -i 's/([^\s])= default;/\1 = default;/g'		ack "default" -l --print0 \| xargs -0 -n 1 sed -E -i 's/([^\s])= default;/\1 = default;/g'
		+
		+	===C++11: Use default member initialization ===
		+
		+	Instead of:
		+
		+	<pre>
		+	// vtkMRMLFooNode.h
		+	class VTK_MRML_EXPORT vtkMRMLFooNode : public vtkMRMLAbstractBarNode
		+	{
		+	[...]
		+
		+	bool DoSomething;
		+	int InteractionMode;
		+	}
		+
		+	// vtkMRMLFooNode.cxx
		+	vtkMRMLFooNode::vtkMRMLFooNode()
		+	: DoSomething(true)
		+	, FooMode(FooModeAwesome)
		+	{
		+	[...]
		+	}
		+	</pre>
		+
		+	Replace with:
		+
		+	<pre>
		+	// vtkMRMLFooNode.h
		+	class VTK_MRML_EXPORT vtkMRMLFooNode : public vtkMRMLAbstractBarNode
		+	{
		+	[...]
		+
		+	bool DoSomething{true};
		+	int FooMode{FooModeAwesome};
		+	};
		+
		+	// vtkMRMLFooNode.cxx
		+	vtkMRMLFooNode::vtkMRMLFooNode()
		+	{
		+	[...]
		+	}
		+
		+	// or this if constructor is empty after removing old-style default initialization
		+
		+	// vtkMRMLFooNode.cxx
		+	vtkMRMLFooNode::vtkMRMLFooNode() = default;
		+	</pre>
		+
		+
		+	Same approach than before, use the compile_commands.json and clang-tidy in Slicer-build.
		+
		+	run-clang-tidy.py -checks=-,modernize-use-default-member-init -header-filter=. -fix
		+
		+
		+	<b>References:</b>
		+
		+	https://clang.llvm.org/extra/clang-tidy/checks/modernize-use-default-member-init.html

@@ Line 322: / Line 322: @@
 Replace for:
-   virtual ~DataRequest()= default;
+   virtual ~DataRequest() = default;
 Same approach than before, use the compile_commands.json and clang-tidy in Slicer-build.

@@ Line 328: / Line 328: @@
    run-clang-tidy.py -checks=-*,modernize-use-equals-default -header-filter=.* -fix
-Because we run it in parallel, multiple occurrences of = delete might have been added. Fix them with:
+Because we run it in parallel, multiple colons ;; might have been added. Fix them with:
   for n in `seq 1 15`;

← Older revision		Revision as of 20:38, 16 March 2019
Line 314:		Line 314:

	Next step in this area would be to move these declarations to the public interface (currently they are private).		Next step in this area would be to move these declarations to the public interface (currently they are private).
		+
		+
		+	===C++11: Update source code to use = default ===
		+
		+	Instead of:
		+	virtual ~DataRequest(){}
		+
		+	Replace for:
		+	virtual ~DataRequest()= default;
		+
		+	Same approach than before, use the compile_commands.json and clang-tidy in Slicer-build.
		+
		+	run-clang-tidy.py -checks=-,modernize-use-equals-default -header-filter=. -fix
		+
		+	Because we run it in parallel, multiple occurrences of = delete might have been added. Fix them with:
		+
		+	for n in `seq 1 15`;
		+	do
		+	ack "default" -l --print0 \| xargs -0 -n 1 sed -i 's/= default;;/= default;/g'
		+	done
		+
		+	Add an empty space before = default if there is none:
		+	ack "default" -l --print0 \| xargs -0 -n 1 sed -E -i 's/([^\s])= default;/\1 = default;/g'

← Older revision		Revision as of 19:23, 16 March 2019
Line 312:		Line 312:
	ack "delete" -l --print0 \| xargs -0 -n 1 sed -E -i 's@delete;\s\/\s*purposely [nN]ot [iI]mplemented\.?@delete;@g'		ack "delete" -l --print0 \| xargs -0 -n 1 sed -E -i 's@delete;\s\/\s*purposely [nN]ot [iI]mplemented\.?@delete;@g'
	ack "delete" -l --print0 \| xargs -0 -n 1 sed -E -i 's@delete ITK\_DELETED\_FUNCTION;@delete;@g'		ack "delete" -l --print0 \| xargs -0 -n 1 sed -E -i 's@delete ITK\_DELETED\_FUNCTION;@delete;@g'
		+
		+	Next step in this area would be to move these declarations to the public interface (currently they are private).

@@ Line 309: / Line 309: @@
 And also delete comment /// Not implemented, as now it is clear with = delete.
-   ack "delete" -l --print0 | xargs -0 -n 1 sed -E -i 's@delete;[[:space:]]*\/*\s*[nN]ot [iI]mplemented\.?@delete;@g'
+   ack "delete" -l --print0 | xargs -0 -n 1 sed -E -i 's@delete;\s*\/*\s*[nN]ot [iI]mplemented\.?@delete;@g'
-   ack "delete" -l --print0 | xargs -0 -n 1 sed -E -i 's@delete;[[:space:]]*\/*\s*purposely [nN]ot [iI]mplemented\.?@delete;@g'
+   ack "delete" -l --print0 | xargs -0 -n 1 sed -E -i 's@delete;\s*\/*\s*purposely [nN]ot [iI]mplemented\.?@delete;@g'
    ack "delete" -l --print0 | xargs -0 -n 1 sed -E -i 's@delete ITK\_DELETED\_FUNCTION;@delete;@g'

← Older revision		Revision as of 19:16, 16 March 2019
Line 298:		Line 298:

	run-clang-tidy.py -checks=-,modernize-use-equals-delete -header-filter=. -fix		run-clang-tidy.py -checks=-,modernize-use-equals-delete -header-filter=. -fix
		+
		+	Because we run it in parallel, multiple occurrences of = delete might have been added. Fix them with:
		+
		+	for n in `seq 1 15`;
		+	do
		+	ack "= delete = delete" -l --print0 \| xargs -0 -n 1 sed -i \
		+	's/= delete = delete/= delete/g'
		+	done
		+
		+	And also delete comment /// Not implemented, as now it is clear with = delete.
		+
		+	ack "delete" -l --print0 \| xargs -0 -n 1 sed -E -i 's@delete;[[:space:]]\/[[:space:]]*[nN]ot [iI]mplemented\.?@delete;@g'
		+	ack "delete" -l --print0 \| xargs -0 -n 1 sed -E -i 's@delete;[[:space:]]\/[[:space:]]*purposely [nN]ot [iI]mplemented\.?@delete;@g'
		+	ack "delete" -l --print0 \| xargs -0 -n 1 sed -E -i 's@delete ITK\_DELETED\_FUNCTION;@delete;@g'