Documentation/Nightly/Developers/Tutorials/MigrationGuide/ITK4-to-ITK5 - Revision history

JChris.FillionR: /* SimpleFastMutexLock, FastMutexLock and MutexLock are deprecated */

2019-05-01T06:30:42Z

SimpleFastMutexLock, FastMutexLock and MutexLock are deprecated

JChris.FillionR: /* itkMultiThreader refactor */

2019-04-17T14:33:47Z

itkMultiThreader refactor

Phcerdan: /* Transition from ITK4 to ITK5 */

2019-03-22T16:52:53Z

Transition from ITK4 to ITK5

Phcerdan: /* Transition from ITK4 to ITK5 */

2019-03-22T16:23:39Z

Transition from ITK4 to ITK5

JChris.FillionR at 20:29, 8 March 2019

2019-03-08T20:29:57Z

JChris.FillionR: /* itkMultiThreader refactor */

2019-03-08T20:16:01Z

itkMultiThreader refactor

JChris.FillionR at 20:15, 8 March 2019

2019-03-08T20:15:40Z

JChris.FillionR: /* Python */

2019-03-08T20:06:19Z

Python

JChris.FillionR: /* Dead code after update to Qt >= 5.6.0 */

2019-03-08T20:05:42Z

Dead code after update to Qt >= 5.6.0

JChris.FillionR: /* Dead code after update to Qt >= 5.6.0 */

2019-03-08T20:04:33Z

Dead code after update to Qt >= 5.6.0

@@ Line 65: / Line 65: @@
    FastMutexLock
    MutexLock
 </pre>
@@ Line 72: / Line 75: @@
    std::mutex
 </pre>

@@ Line 31: / Line 31: @@
    itk::MultiThreader::Pointer ProcessingThreader;
 </pre>
@@ Line 38: / Line 44: @@
    itk::PlatformMultiThreader::Pointer ProcessingThreader;
 </pre>

← Older revision		Revision as of 16:52, 22 March 2019
Line 5:		Line 5:

	Make also sure to read through the [https://github.com/InsightSoftwareConsortium/ITK/blob/master/Documentation/ITK5MigrationGuide.md ITK 5 migration guide].		Make also sure to read through the [https://github.com/InsightSoftwareConsortium/ITK/blob/master/Documentation/ITK5MigrationGuide.md ITK 5 migration guide].
		+
		+	[https://github.com/InsightSoftwareConsortium/ITK/tree/master/Utilities/ITKv5Preparation Utilities/ITKv5Preparation] directory contains bash scripts which have been used to update ITK to version 5. These scripts can assist with updating external code bases to ITK 5 content and style.

	===Upgrading to ITKv5 or keep using ITKv4 GenerateThreadedData===		===Upgrading to ITKv5 or keep using ITKv4 GenerateThreadedData===

← Older revision		Revision as of 16:23, 22 March 2019
Line 5:		Line 5:

	Make also sure to read through the [https://github.com/InsightSoftwareConsortium/ITK/blob/master/Documentation/ITK5MigrationGuide.md ITK 5 migration guide].		Make also sure to read through the [https://github.com/InsightSoftwareConsortium/ITK/blob/master/Documentation/ITK5MigrationGuide.md ITK 5 migration guide].
		+
		+	===Upgrading to ITKv5 or keep using ITKv4 GenerateThreadedData===
		+	If the ThreadedGenerateData does not use threadId, change the name of the function to DynamicThreadedGenerateData
		+	Replace:
		+	<pre>
		+	void ThreadedGenerateData( const OutputRegionType& threadRegion, ThreadIdType threadId )
		+	</pre>
		+	with:
		+	<pre>
		+	void DynamicThreadedGenerateData( const OutputRegionType& threadRegion )
		+	</pre>
		+
		+	If you want to keep using the ITKv4 thread system (with ThreadedGenerateData), add to the constructor of your ITK class:
		+	<pre>
		+	this->DynamicMultiThreadingOff();
		+	</pre>

	===itkMultiThreader refactor===		===itkMultiThreader refactor===

← Older revision		Revision as of 20:29, 8 March 2019
Line 43:		Line 43:
	std::mutex		std::mutex
	</pre>		</pre>
−
−	~~===Dead code after update to Qt >= 5.6.0===~~
−
−	~~Remove any branch checking of QT_VERSION lesser than 5.6.0~~
−	~~<pre>~~
−	~~#include <QtGlobal>~~
−	~~#if(QT_VERSION < QT_VERSION_CHECKS(5, 6, 0))~~
−	~~// Obsolete Qt4 code~~
−	~~#include <QDesignerCustomWidgetInterface>~~
−	~~#else~~
−	~~// Qt5 code~~
−	~~#include <QtUiPlugin/QDesignerCustomWidgetInterface>~~
−	~~#endif~~
−
−	~~[...]~~
−
−	~~class Q_SLICER_MODULE_SEGMENTATIONS_WIDGETS_PLUGINS_EXPORT qSlicerSegmentationsModuleWidgetsAbstractPlugin~~
−	~~: public QDesignerCustomWidgetInterface~~
−	{
−	~~#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))~~
−	~~Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QDesignerCustomWidgetInterface")~~
−	~~#endif~~
−	~~Q_INTERFACES(QDesignerCustomWidgetInterface);~~
−	}
−	~~</pre>~~
−
−	~~After cleaning:~~
−
−	~~<pre>~~
−	~~#include <QtUiPlugin/QDesignerCustomWidgetInterface>~~
−
−	~~[...]~~
−
−	~~class Q_SLICER_MODULE_SEGMENTATIONS_WIDGETS_PLUGINS_EXPORT qSlicerSegmentationsModuleWidgetsAbstractPlugin~~
−	~~: public QDesignerCustomWidgetInterface~~
−	{
−	~~Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QDesignerCustomWidgetInterface")~~
−	~~Q_INTERFACES(QDesignerCustomWidgetInterface);~~
−	}
−	~~</pre>~~
−
−	~~====Python====~~
−
−	~~This migration guide points becomes obsolete:~~
−	~~[[Documentation/Nightly/Developers/Tutorials/MigrationGuide#Qt5:_Fix_error:_.E2.80.98class_QHeaderView.E2.80.99_has_no_member_named_.E2.80.98setResizeMode.E2.80.99]]~~
−
−	~~Only Qt5 needs to be supported, so the following code can be simplified:~~
−
−	~~Before:~~
−	~~_setSectionResizeMode(self.horizontalHeader(), 0, qt.QHeaderView.Stretch)~~
−	~~def _setSectionResizeMode(header, args, *kwargs):~~
−	~~if version.parse(qt.Qt.qVersion()) < version.parse("5.0.0"):~~
−	~~header.setResizeMode(args, *kwargs)~~
−	~~else:~~
−	~~header.setSectionResizeMode(args, *kwargs)~~
−
−	~~After:~~
−	~~self.horizontalHeader(0, qt.QHeaderView.Stretch)~~

@@ Line 9: / Line 9: @@
 Replace lines like:
    #include <itkMultiThreader.h>
    itk::MultiThreader::Pointer ProcessingThreader;
 with:
    #include <itkPlatformMultiThreader.h>
    itk::PlatformMultiThreader::Pointer ProcessingThreader;
 ===SimpleFastMutexLock, FastMutexLock and MutexLock are deprecated===

@@ Line 2: / Line 2: @@
 This section lists categories of code changes necessary to build Slicer with ITK 5. Each category has a short description, an example error message, a suggested upgrade path, and references to relevant commits.
-Referencing this list might be helpful if Slicer extensions require updates to be compatible with ITK 5.
+Referencing this list might be helpful if Slicer extensions requiring updates to be compatible with ITK 5.
-Also check the ITK migration guide if more info is needed:
+Make also sure to read through the [https://github.com/InsightSoftwareConsortium/ITK/blob/master/Documentation/ITK5MigrationGuide.md ITK 5 migration guide].
 ===itkMultiThreader refactor===
@@ Line 22: / Line 21: @@
 Replace:
    #include "itkSimpleFastMutexLock.h"
    #include "itkFastMutexLock.h"
    #include "itkMutexLock.h"
    SimpleFastMutexLock
    FastMutexLock
    MutexLock
 with:
    #include <mutex>
    std::mutex
 ===Dead code after update to Qt >= 5.6.0===

@@ Line 76: / Line 76: @@
 This migration guide points becomes obsolete:
-https://www.slicer.org/wiki/Documentation/Nightly/Developers/Tutorials/MigrationGuide#Qt5:_Fix_error:_.E2.80.98class_QHeaderView.E2.80.99_has_no_member_named_.E2.80.98setResizeMode.E2.80.99
+[[Documentation/Nightly/Developers/Tutorials/MigrationGuide#Qt5:_Fix_error:_.E2.80.98class_QHeaderView.E2.80.99_has_no_member_named_.E2.80.98setResizeMode.E2.80.99]]
 Only Qt5 needs to be supported, so the following code can be simplified:

@@ Line 37: / Line 37: @@
 Remove any branch checking of QT_VERSION lesser than 5.6.0
 <pre>
    #if(QT_VERSION < QT_VERSION_CHECKS(5, 6, 0))
    // Obsolete Qt4 code
@@ Line 44: / Line 45: @@
    #include <QtUiPlugin/QDesignerCustomWidgetInterface>
    #endif
    class Q_SLICER_MODULE_SEGMENTATIONS_WIDGETS_PLUGINS_EXPORT qSlicerSegmentationsModuleWidgetsAbstractPlugin
@@ Line 57: / Line 60: @@
 After cleaning:
    #include <QtUiPlugin/QDesignerCustomWidgetInterface>
    class Q_SLICER_MODULE_SEGMENTATIONS_WIDGETS_PLUGINS_EXPORT qSlicerSegmentationsModuleWidgetsAbstractPlugin
        : public QDesignerCustomWidgetInterface
@@ Line 64: / Line 71: @@
      Q_INTERFACES(QDesignerCustomWidgetInterface);
+   }
 ====Python====